SANDBOX-800: save CRs when test fails by rsoaresd · Pull Request #61582 · openshift/release

rsoaresd · 2025-02-12T16:56:00Z

Description

Save CRs when test fails

Issue ticket number and link

openshift-ci-robot · 2025-02-12T16:57:52Z

@rsoaresd, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: configuration has 4 errors:

 * tests[0].post[0]: only one of `ref`, `chain`, or a literal test step can be set
 * tests[0].post[0]: `from` or `from_image` is required
 * tests[0].post[0]: `commands` is required
 * 'tests[0].post[0].resources' should have at least one request or limit

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

openshift-ci-robot · 2025-02-12T17:02:48Z

@rsoaresd, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from candidate revision of release repo: failed to load ci-operator configuration from release repo: invalid ci-operator config: configuration has 4 errors:

 * tests[0].test[1]: only one of `ref`, `chain`, or a literal test step can be set
 * tests[0].test[1]: `from` or `from_image` is required
 * tests[0].test[1]: `commands` is required
 * 'tests[0].test[1].resources' should have at least one request or limit

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

rsoaresd · 2025-02-12T17:45:38Z

/pj-rehearse

openshift-ci-robot · 2025-02-12T17:45:42Z

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rsoaresd · 2025-02-12T22:55:48Z

/pj-rehearse

openshift-ci-robot · 2025-02-12T22:55:50Z

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rsoaresd · 2025-02-13T10:59:23Z

/pj-rehearse pull-ci-codeready-toolchain-host-operator-master-e2e

openshift-ci-robot · 2025-02-13T10:59:26Z

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rsoaresd · 2025-02-13T15:05:09Z

/pj-rehearse

openshift-ci-robot · 2025-02-13T15:05:12Z

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rsoaresd · 2025-02-13T18:23:21Z

/pj-rehearse

openshift-ci-robot · 2025-02-13T18:23:24Z

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci-robot · 2025-02-13T18:24:41Z

@rsoaresd: This pull request references SANDBOX-800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-02-13T18:25:23Z

@rsoaresd: This pull request references SANDBOX-800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Description

Save CRs when test fails

Issue ticket number and link

SANDBOX-800

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

alexeykazakov

We need to add jrosental to the owners and reviewers too.
There are also some JSONs which don't include jrosental but I'm not sure if those were generated?

alexeykazakov · 2025-02-13T20:15:16Z

ci-operator/step-registry/codeready-toolchain/OWNERS

+- rajivnathan
+- ranakan19
+- rsoaresd
+- xcoulon


Suggested change

- xcoulon

- xcoulon

- jrosental

alexeykazakov · 2025-02-13T20:15:29Z

ci-operator/step-registry/codeready-toolchain/OWNERS

+- rajivnathan
+- ranakan19
+- rsoaresd
+- xcoulon


Suggested change

- xcoulon

- xcoulon

- jrosental

alexeykazakov · 2025-02-13T20:15:48Z

ci-operator/step-registry/codeready-toolchain/aws/OWNERS

+- rajivnathan
+- ranakan19
+- rsoaresd
+- xcoulon


Suggested change

- xcoulon

- xcoulon

- jrosental

alexeykazakov · 2025-02-13T20:15:58Z

ci-operator/step-registry/codeready-toolchain/aws/OWNERS

+- rajivnathan
+- ranakan19
+- rsoaresd
+- xcoulon


Suggested change

- xcoulon

- xcoulon

- jrosental

alexeykazakov · 2025-02-13T20:17:11Z

ci-operator/step-registry/codeready-toolchain/gather/OWNERS

+- rajivnathan
+- ranakan19
+- rsoaresd
+- xcoulon


Suggested change

- xcoulon

- xcoulon

- jrosental

alexeykazakov · 2025-02-13T20:17:21Z

ci-operator/step-registry/codeready-toolchain/gather/OWNERS

+- rajivnathan
+- ranakan19
+- rsoaresd
+- xcoulon


Suggested change

- xcoulon

- xcoulon

- jrosental

So sorry! I added it here: 3c984a4

I also added jrosental to the OWNERS of the repos (if not in OWNERS of the repos that runs the e2e jobs - toolchain-e2e, host-operator, member-operator, registration-service and workload-analyzer - his name will be removed in theses. For more info, check this Slack thread):

add jrosental as owner codeready-toolchain/toolchain-e2e#1118

add jrosental as owner codeready-toolchain/host-operator#1141

add jrosental as owner codeready-toolchain/member-operator#623

https://github.com/codeready-toolchain/workload-analyzer/pull/119

add jrosental as owner codeready-toolchain/registration-service#509

add jrosental as owner codeready-toolchain/api#460

add jrosental as owner codeready-toolchain/toolchain-common#456

P.S. I also added him in api and toolchain-common to update there

rajivnathan

Nice 👍

MatousJobanek · 2025-02-14T07:49:15Z

ci-operator/step-registry/codeready-toolchain/gather/codeready-toolchain-gather-commands.sh

+queue ${ARTIFACT_DIR}/bannedusers.json oc --insecure-skip-tls-verify --request-timeout=5s get bannedusers.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/idlers.json oc --insecure-skip-tls-verify --request-timeout=5s get idlers.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/masteruserrecords.json oc --insecure-skip-tls-verify --request-timeout=5s get masteruserrecords.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/memberoperatorconfigs.json oc --insecure-skip-tls-verify --request-timeout=5s get memberoperatorconfigs.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/memberstatuses.json oc --insecure-skip-tls-verify --request-timeout=5s get memberstatuses.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/notifications.json oc --insecure-skip-tls-verify --request-timeout=5s get notifications.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/nstemplatesets.json oc --insecure-skip-tls-verify --request-timeout=5s get nstemplatesets.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/nstemplatetiers.json oc --insecure-skip-tls-verify --request-timeout=5s get nstemplatetiers.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/proxyplugins.json oc --insecure-skip-tls-verify --request-timeout=5s get proxyplugins.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/socialevents.json oc --insecure-skip-tls-verify --request-timeout=5s get socialevents.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/spacebindings.json oc --insecure-skip-tls-verify --request-timeout=5s get spacebindings.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/spacebindingrequests.json oc --insecure-skip-tls-verify --request-timeout=5s get spacebindingrequests.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/spaceprovisionerconfigs.json oc --insecure-skip-tls-verify --request-timeout=5s get spaceprovisionerconfigs.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/spacerequests.json oc --insecure-skip-tls-verify --request-timeout=5s get spacerequests.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/spaces.json oc --insecure-skip-tls-verify --request-timeout=5s get spaces.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/tiertemplates.json oc --insecure-skip-tls-verify --request-timeout=5s get tiertemplates.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/tiertemplaterevisions.json oc --insecure-skip-tls-verify --request-timeout=5s get tiertemplaterevisions.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/toolchainclusters.json oc --insecure-skip-tls-verify --request-timeout=5s get toolchainclusters.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/toolchainconfigs.json oc --insecure-skip-tls-verify --request-timeout=5s get toolchainconfigs.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/toolchainstatuses.json oc --insecure-skip-tls-verify --request-timeout=5s get toolchainstatuses.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/usersignups.json oc --insecure-skip-tls-verify --request-timeout=5s get usersignups.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/usertiers.json oc --insecure-skip-tls-verify --request-timeout=5s get usertiers.toolchain.dev.openshift.com --all-namespaces -o json
+queue ${ARTIFACT_DIR}/workspaces.json oc --insecure-skip-tls-verify --request-timeout=5s get workspaces.toolchain.dev.openshift.com --all-namespaces -o json


when we add (or remove) a CRD, then we would need to update this script. I would try to make it more generic - something like this:

CRD_LIST=$(kubectl get crds -o jsonpath='{.items[?(@.spec.group=="toolchain.dev.openshift.com")].metadata.name}') for CRD in ${CRD_LIST}; do queue ${ARTIFACT_DIR}/${CRD}.json oc --insecure-skip-tls-verify --request-timeout=5s get ${CRD} --all-namespaces -o json done

so it iterates over the available CRDs instead of hard-coding them

Thank you so much!! I agree! Addressed in 2dc90e3

alexeykazakov · 2025-02-14T17:54:30Z

/retest

alexeykazakov · 2025-02-14T17:56:31Z

/pj-rehearse auto-ack

openshift-ci-robot · 2025-02-14T17:56:33Z

@alexeykazakov: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci-robot · 2025-02-25T09:34:04Z

[REHEARSALNOTIFIER]
@rsoaresd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-codeready-toolchain-registration-service-master-e2e	codeready-toolchain/registration-service	presubmit	Ci-operator config changed
pull-ci-codeready-toolchain-member-operator-master-e2e	codeready-toolchain/member-operator	presubmit	Ci-operator config changed
pull-ci-codeready-toolchain-host-operator-master-e2e	codeready-toolchain/host-operator	presubmit	Ci-operator config changed
pull-ci-codeready-toolchain-workload-analyzer-master-e2e	codeready-toolchain/workload-analyzer	presubmit	Ci-operator config changed
pull-ci-codeready-toolchain-toolchain-e2e-master-e2e	codeready-toolchain/toolchain-e2e	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

rsoaresd · 2025-02-25T11:04:58Z

/pj-rehearse

openshift-ci-robot · 2025-02-25T11:05:02Z

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

ranakan19

Awesome! Looking forward to being able to see CRs in artifacts

openshift-ci · 2025-02-25T14:55:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeykazakov, fbm3307, MatousJobanek, rajivnathan, ranakan19, rsoaresd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/codeready-toolchain/host-operator/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/config/codeready-toolchain/member-operator/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/config/codeready-toolchain/registration-service/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/config/codeready-toolchain/toolchain-e2e/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/config/codeready-toolchain/workload-analyzer/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/jobs/codeready-toolchain/host-operator/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/jobs/codeready-toolchain/member-operator/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/jobs/codeready-toolchain/registration-service/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/jobs/codeready-toolchain/toolchain-e2e/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]
~~ci-operator/jobs/codeready-toolchain/workload-analyzer/OWNERS~~ [MatousJobanek,alexeykazakov,fbm3307,rajivnathan,ranakan19,rsoaresd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

rsoaresd · 2025-02-25T15:52:18Z

/pj-rehearse ack

openshift-ci-robot · 2025-02-25T15:52:26Z

@rsoaresd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci bot requested review from dgoodwin and fbm3307 February 12, 2025 16:56

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025

save CRS when test fails

a68e5c4

rsoaresd force-pushed the save_crs_when_test_fails branch from 4cbe2d4 to a68e5c4 Compare February 13, 2025 17:48

rsoaresd changed the title ~~save crs when test fails~~ SANDBOX-800: save crs when test fails Feb 13, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 13, 2025

rsoaresd changed the title ~~SANDBOX-800: save crs when test fails~~ SANDBOX-800: save CRs when test fails Feb 13, 2025

alexeykazakov reviewed Feb 13, 2025

View reviewed changes

rajivnathan approved these changes Feb 14, 2025

View reviewed changes

openshift-ci bot assigned rajivnathan Feb 14, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025

MatousJobanek reviewed Feb 14, 2025

View reviewed changes

add jrosental to OWNERS

3c984a4

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2025

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 14, 2025

Merge branch 'master' into save_crs_when_test_fails

e12ab95

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 14, 2025

requested changes

2dc90e3

openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 14, 2025

MatousJobanek approved these changes Feb 14, 2025

View reviewed changes

openshift-ci bot assigned MatousJobanek Feb 14, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2025

alexeykazakov approved these changes Feb 14, 2025

View reviewed changes

openshift-ci bot assigned alexeykazakov Feb 14, 2025

fix

ee8480f

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025

fix

67ece3f

ranakan19 approved these changes Feb 25, 2025

View reviewed changes

openshift-ci bot assigned ranakan19 Feb 25, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 25, 2025

fbm3307 approved these changes Feb 25, 2025

View reviewed changes

openshift-ci bot assigned fbm3307 Feb 25, 2025

openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Feb 25, 2025

openshift-merge-bot bot merged commit 1dc6d3d into openshift:master Feb 25, 2025
21 of 22 checks passed

Conversation

rsoaresd commented Feb 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue ticket number and link

Uh oh!

openshift-ci-robot commented Feb 12, 2025

Uh oh!

openshift-ci-robot commented Feb 12, 2025

Uh oh!

rsoaresd commented Feb 12, 2025

Uh oh!

openshift-ci-robot commented Feb 12, 2025

Uh oh!

rsoaresd commented Feb 12, 2025

Uh oh!

openshift-ci-robot commented Feb 12, 2025

Uh oh!

rsoaresd commented Feb 13, 2025

Uh oh!

openshift-ci-robot commented Feb 13, 2025

Uh oh!

rsoaresd commented Feb 13, 2025

Uh oh!

openshift-ci-robot commented Feb 13, 2025

Uh oh!

rsoaresd commented Feb 13, 2025

Uh oh!

openshift-ci-robot commented Feb 13, 2025

Uh oh!

openshift-ci-robot commented Feb 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 13, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue ticket number and link

Uh oh!

alexeykazakov left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajivnathan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexeykazakov commented Feb 14, 2025

Uh oh!

alexeykazakov commented Feb 14, 2025

Uh oh!

openshift-ci-robot commented Feb 14, 2025

Uh oh!

openshift-ci-robot commented Feb 25, 2025

Uh oh!

rsoaresd commented Feb 25, 2025

Uh oh!

openshift-ci-robot commented Feb 25, 2025

Uh oh!

ranakan19 left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 25, 2025

Uh oh!

rsoaresd commented Feb 25, 2025

rsoaresd commented Feb 12, 2025 •

edited

Loading

openshift-ci-robot commented Feb 13, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Feb 13, 2025 •

edited by openshift-ci bot

Loading